Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: feat: add yurtadm binaries release workflow #1602

Merged
merged 1 commit into from
Jul 12, 2023
Merged

backport: feat: add yurtadm binaries release workflow #1602

merged 1 commit into from
Jul 12, 2023

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

backport #1577 to branch release-v1.1

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

backport #1577 to branch release-v1.1

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added approved approved size/M size/M: 30-99 labels Jul 11, 2023
@openyurt-bot openyurt-bot added size/L size/L: 100-499 and removed size/M size/M: 30-99 labels Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-v1.1@f5563f7). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release-v1.1    #1602   +/-   ##
===============================================
  Coverage                ?   49.47%           
===============================================
  Files                   ?       96           
  Lines                   ?    13054           
  Branches                ?        0           
===============================================
  Hits                    ?     6458           
  Misses                  ?     6060           
  Partials                ?      536
Flag Coverage Δ
unittests 49.47% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

YTGhost
YTGhost reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Jul 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rambohe-ch rambohe-ch merged commit e059ae0 into openyurtio:release-v1.1 Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YTGhost YTGhost YTGhost left review comments

@charleszheng44 charleszheng44 Awaiting requested review from charleszheng44

@luckymrwang luckymrwang Awaiting requested review from luckymrwang

Assignees

@YTGhost YTGhost

Labels
approved approved lgtm lgtm size/L size/L: 100-499
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rambohe-ch @openyurt-bot @YTGhost